feat: Add Upload with v2 API by LouisCAD · Pull Request #595 · Infomaniak/android-SwissTransfer

LouisCAD · 2026-03-03T17:08:01Z

Will need an update to the KMP library.

Uses Splitties Preferences to observe shared preferences, and access it off the main thread.

This commit also: - Introduces middle interfaces (UploadSessionStarter & TransferUploader) - Adds AbandonedTransferCleanupWorker - Updates SwissTransferInjectionModule to support these - Prepares support for transfer titles

Copilot

Pull request overview

Adds support for starting and performing uploads via the SwissTransfer v2 API while keeping the legacy v1 upload flow available, and updates surrounding app plumbing (account/onboarding prefs, URL building, cleanup workers) to accommodate the dual-stack upload pipeline.

Changes:

Introduces v2 upload session start + v2 transfer uploader, and routes upload execution based on whether the session destination is v1 or v2 (Xor).
Adds a v2 “abandoned transfer” cleanup worker and integrates it into the upload failure/cancel path.
Extends transfer/new-transfer models (e.g., title, linkId, apiSource) and updates UI/viewmodels/previews accordingly.

Reviewed changes

Copilot reviewed 26 out of 26 changed files in this pull request and generated 9 comments.

Show a summary per file

File	Description
app/src/test/java/com/infomaniak/swisstransfer/TransferSectionGroupingTest.kt	Updates test fixture for new `TransferUi` fields.
app/src/main/java/com/infomaniak/swisstransfer/upload/UploadSessionStarterV2.kt	Adds v2 session starter using `UploadV2Manager`.
app/src/main/java/com/infomaniak/swisstransfer/upload/UploadSessionStarterV1.kt	Refactors v1 starter to extend shared `UploadSessionStarter` and return an `Xor`.
app/src/main/java/com/infomaniak/swisstransfer/upload/UploadSessionStarterInterface.kt	Introduces shared abstraction + unified `Result` contract for v1/v2 session start.
app/src/main/java/com/infomaniak/swisstransfer/upload/UploadSessionManager.kt	Chooses v1/v2 uploader based on destination and adjusts URL + cleanup scheduling.
app/src/main/java/com/infomaniak/swisstransfer/upload/TransferUploaderV2.kt	New v2 chunk uploader and finalize flow (including link UUID).
app/src/main/java/com/infomaniak/swisstransfer/upload/TransferUploaderInterface.kt	New shared uploader interface + `UploadResult` (transferId/linkId).
app/src/main/java/com/infomaniak/swisstransfer/upload/TransferUploader.kt	Renames legacy uploader to `TransferUploaderV1` and adapts to interface/result type.
app/src/main/java/com/infomaniak/swisstransfer/upload/NewTransferParamsExt.kt	Passes `title` into the upload session request.
app/src/main/java/com/infomaniak/swisstransfer/upload/NewTransferParams.kt	Adds nullable `title` to new transfer params.
app/src/main/java/com/infomaniak/swisstransfer/upload/AbandonedTransferV2CleanupWorker.kt	Adds v2 cleanup worker to cancel abandoned v2 transfers.
app/src/main/java/com/infomaniak/swisstransfer/ui/utils/AccountUtils.kt	Reworks activation to sync Sentry user + load KMP user based on onboarding state.
app/src/main/java/com/infomaniak/swisstransfer/ui/utils/AccountPreferences.kt	Migrates to Splitties `Preferences` + adds `isOnboardingDoneFlow` migration logic.
app/src/main/java/com/infomaniak/swisstransfer/ui/screen/newtransfer/pickfiles/PickFilesViewModel.kt	Adds transfer title state and includes it in `NewTransferParams`.
app/src/main/java/com/infomaniak/swisstransfer/ui/screen/main/transferdetails/TransferDetailsViewModel.kt	Treats `PENDING_UPLOAD` as loading.
app/src/main/java/com/infomaniak/swisstransfer/ui/screen/main/settings/SettingsValidityPeriodScreen.kt	Uses `ValidityPeriod.days` for pluralization.
app/src/main/java/com/infomaniak/swisstransfer/ui/screen/main/settings/SettingsScreen.kt	Uses `ValidityPeriod.days` for display.
app/src/main/java/com/infomaniak/swisstransfer/ui/previewparameter/GroupedTransfersPreviewParameterProvider.kt	Updates preview data for `linkId` and `apiSource`.
app/src/main/java/com/infomaniak/swisstransfer/ui/OnboardingActivity.kt	Writes onboarding completion via new `AccountPreferences` accessor.
app/src/main/java/com/infomaniak/swisstransfer/ui/MainApplication.kt	Initializes Splitties appCtx + core network config earlier; activates AccountUtils.
app/src/main/java/com/infomaniak/swisstransfer/ui/LaunchActivity.kt	Writes onboarding flag via new `AccountPreferences` accessor.
app/src/main/java/com/infomaniak/swisstransfer/di/SwissTransferInjectionModule.kt	Provides v1/v2 upload managers and selects the proper `UploadSessionStarter`.
app/src/main/java/com/infomaniak/swisstransfer/di/ApplicationModule.kt	Adjusts login appUID and adds a logcat callback for login issues.
app/build.gradle.kts	Adds Splitties preferences dependency.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

app/src/main/java/com/infomaniak/swisstransfer/upload/UploadSessionManager.kt

app/src/main/java/com/infomaniak/swisstransfer/upload/AbandonedTransferV2CleanupWorker.kt

Copilot · 2026-03-05T14:11:38Z

app/src/main/java/com/infomaniak/swisstransfer/upload/AbandonedTransferV2CleanupWorker.kt

+    private fun isBeyondBackedAutoCleanup(): Boolean {
+        val requestUtcTimestampMillis = inputData.getLong(DataKeys.REQUEST_UTC_TIMESTAMP_MILLIS, 0L)
+        val giveUpUtcTimestampMillis = requestUtcTimestampMillis + backendAutoCleanupDelay.inWholeMilliseconds
+        return System.currentTimeMillis() >= giveUpUtcTimestampMillis
+    }
+
+    override suspend fun doWork(): Result {
+        if (isBeyondBackedAutoCleanup()) return Result.failure()


Method name isBeyondBackedAutoCleanup looks like a typo ("Backed" vs "Backend"), especially given backendAutoCleanupDelay below. Consider renaming to something like isBeyondBackendAutoCleanup for clarity/searchability.

Suggested change

private fun isBeyondBackedAutoCleanup(): Boolean {

val requestUtcTimestampMillis = inputData.getLong(DataKeys.REQUEST_UTC_TIMESTAMP_MILLIS, 0L)

val giveUpUtcTimestampMillis = requestUtcTimestampMillis + backendAutoCleanupDelay.inWholeMilliseconds

return System.currentTimeMillis() >= giveUpUtcTimestampMillis

}

override suspend fun doWork(): Result {

if (isBeyondBackedAutoCleanup()) return Result.failure()

private fun isBeyondBackendAutoCleanup(): Boolean {

val requestUtcTimestampMillis = inputData.getLong(DataKeys.REQUEST_UTC_TIMESTAMP_MILLIS, 0L)

val giveUpUtcTimestampMillis = requestUtcTimestampMillis + backendAutoCleanupDelay.inWholeMilliseconds

return System.currentTimeMillis() >= giveUpUtcTimestampMillis

}

override suspend fun doWork(): Result {

if (isBeyondBackendAutoCleanup()) return Result.failure()

Nice catch.

app/src/main/java/com/infomaniak/swisstransfer/upload/AbandonedTransferV2CleanupWorker.kt

app/src/main/java/com/infomaniak/swisstransfer/upload/TransferUploaderV2.kt

app/src/main/java/com/infomaniak/swisstransfer/upload/UploadSessionManager.kt

app/src/main/java/com/infomaniak/swisstransfer/upload/AbandonedTransferV2CleanupWorker.kt

app/src/main/java/com/infomaniak/swisstransfer/upload/UploadSessionStarterInterface.kt

Copilot · 2026-03-05T14:11:40Z

app/src/main/java/com/infomaniak/swisstransfer/di/ApplicationModule.kt

+                //TODO[Sentry]: Should we forward this to Sentry, or leave it only in logcat for debug?
+                val tag = "LoginIssue"
+                Log.e(tag, message)
+                Log.e(tag, extras.toString())


The sentryCallback currently logs extras.toString() to logcat. Depending on what extras contains (tokens, user identifiers, URLs), this can leak sensitive information on production devices. Consider guarding this behind BuildConfig.DEBUG, redacting known-sensitive keys/values, or sending a sanitized event to Sentry instead of raw logcat output.

Suggested change

Log.e(tag, extras.toString())

if (BuildConfig.DEBUG) {

Log.e(tag, extras.toString())

}

)

…ewparameter/GroupedTransfersPreviewParameterProvider.kt Co-authored-by: Gibran Chevalley <32095402+LunarX@users.noreply.github.com>

…linedTextFields

Already applied

sonarqubecloud · 2026-03-06T16:58:16Z

Quality Gate passed

Issues
7 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
2.5% Duplication on New Code

See analysis details on SonarQube Cloud

LouisCAD added 8 commits March 3, 2026 17:53

refactor: Fix and simplify AccountUtils and AccountPreferences

573d98a

Uses Splitties Preferences to observe shared preferences, and access it off the main thread.

chore: Update usages of ValidityPeriod

17c5cd8

chore: Update TransferUi constructor calls

a6c9707

chore: Update for new TransferStatus enum entry

bbfd7d1

chore: Ensure pre-prod flavor enables pre-prod for the whole app

1cef3f6

chore: Forward login issues from the login library to logcat

24b8c0c

chore: Specify databaseNameOrPath for SwissTransferInjection

07e55fa

chore: Introduce UploadSessionStarterV1 & TransferUploaderV2

bdad1bd

This commit also: - Introduces middle interfaces (UploadSessionStarter & TransferUploader) - Adds AbandonedTransferCleanupWorker - Updates SwissTransferInjectionModule to support these - Prepares support for transfer titles

LouisCAD requested a review from sirambd March 3, 2026 17:08

github-actions bot assigned LouisCAD Mar 3, 2026

LouisCAD enabled auto-merge March 3, 2026 17:08

LouisCAD disabled auto-merge March 3, 2026 17:08

LouisCAD mentioned this pull request Mar 5, 2026

chore: Update for download of v2 transfers #596

Closed

sirambd requested a review from Copilot March 5, 2026 14:05

LouisCAD added 2 commits March 5, 2026 15:06

chore: Remove workaround for parallel upload

aae1bd6

chore: Remove no longer needed commented code

8514d49

Copilot started reviewing on behalf of sirambd March 5, 2026 14:06 View session

chore: Update for download of v2 transfers

4379010

Copilot AI reviewed Mar 5, 2026

View reviewed changes

chore: Add TODO comment regarding duplicated code

bcf94dc

sirambd mentioned this pull request Mar 6, 2026

feat: Download a transfer with password from api v2 #597

Merged

LunarX added 2 commits March 6, 2026 14:09

refactor: Only specify preprod in a single place in the code

1de30e7

feat: Hide download all button and download count for v2 transfers

a2f32a1

LunarX mentioned this pull request Mar 6, 2026

refactor: Only specify preprod in a single place in the code #598

Merged

sirambd added 3 commits March 6, 2026 14:18

refactor: Use mimeType.substringAfterLast directly

a0105b2

refactor: Apply review suggestion

e612538

refactor: Update the TAG name

607a0ca

sirambd approved these changes Mar 6, 2026

View reviewed changes

sirambd enabled auto-merge March 6, 2026 13:23

feat: Download a transfer with password from api v2

5e15a2b

fix: Fix API v2 password header addition logic

ece9411

sirambd disabled auto-merge March 6, 2026 13:27

sirambd and others added 14 commits March 6, 2026 14:44

refactor: Only specify preprod in a single place in the code (#598)

8e6d775

feat: Download a transfer with password from api v2 (#597)

3894071

feat: Hide download all button and download count for v2 transfers (#599

b114808

)

feat: Display the title if available

680c334

chore: Add transferTitlePlaceholder string res

f2138ad

feat: Show Api V2 title if available

fec38db

chore: Update app/src/main/java/com/infomaniak/swisstransfer/ui/previ…

9930181

…ewparameter/GroupedTransfersPreviewParameterProvider.kt Co-authored-by: Gibran Chevalley <32095402+LunarX@users.noreply.github.com>

chore: Use LocalUser to check if user is in apiV2

9334a8a

refactor: Use spacedBy instead of manually adding spacer everywhere

54ae2a5

fix: Make it so EmailAddressTextField has the same top padding as Out…

a989b06

…linedTextFields

refactor: Fix preview parameters

4ce8587

feat: Show Api V2 title if available (#600)

8d1e3c7

Already applied

Refactor pick files screen textfield spacings (#601)

61c0567

chore: Use 7.0.0-SNAPSHOT

354eb60

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Add Upload with v2 API#595

feat: Add Upload with v2 API#595
LouisCAD wants to merge 33 commits intoprotected/v2from
upload-v2

LouisCAD commented Mar 3, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Copilot AI Mar 5, 2026

Uh oh!

LouisCAD Mar 5, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI Mar 5, 2026

Uh oh!

sonarqubecloud bot commented Mar 6, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

LouisCAD commented Mar 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Copilot AI Mar 5, 2026

Choose a reason for hiding this comment

Uh oh!

LouisCAD Mar 5, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI Mar 5, 2026

Choose a reason for hiding this comment

Uh oh!

sonarqubecloud bot commented Mar 6, 2026

Quality Gate passed

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

LouisCAD commented Mar 3, 2026 •

edited

Loading